-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a policy to reauthorize the credential when invalid #2887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adreed-msft
requested review from
gapra-msft,
dphulkar-msft,
vibhansa-msft,
seanmcc-msft,
souravgupta-msft and
tanyasethi-msft
as code owners
December 6, 2024 03:00
gapra-msft
reviewed
Jan 16, 2025
gapra-msft
reviewed
Jan 16, 2025
gapra-msft
approved these changes
Jan 17, 2025
There are some linting errors that need to be addressed. Could you please take a look and resolve them? |
dphulkar-msft
approved these changes
Jan 21, 2025
vibhansa-msft
approved these changes
Jan 22, 2025
gapra-msft
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Feature / Bug Fix: A bit of both actually. With long enough jobs under device code auth, the underlying token could totally time out and cause a job to abruptly fail. This PR adds in a pipeline policy that catches failures of this nature, and provides a prompt to reauthorize on the fly.
Related Links:
Email Subject: "AzCopy always fails trying to download a large file due to token expiration"
ADO Work Item # 29466291
Type of Change
How Has This Been Tested?
TestDestReauthPolicy
ensures the pipeline policy fundamentally works.